[3.7] bpo-35545: Fix asyncio discarding IPv6 scopes (GH-11271)#13379
Merged
Conversation
This PR proposes a solution to [bpo-35545](https://bugs.python.org/issue35545) by adding an optional `flowinfo` and `scopeid` to `asyncio.base_events._ipaddr_info` to carry the full address information into `_ipaddr_info` and avoid discarding IPv6 specific information. Changelog entry & regression tests to come. https://bugs.python.org/issue35545 (cherry picked from commit ac8eb8f) Co-authored-by: Erwan Le Pape <lepaperwan@users.noreply.github.com>
asvetlov
approved these changes
May 17, 2019
Contributor
Author
|
@lepaperwan: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@lepaperwan: Status check is done, and it's a success ✅ . |
Contributor
|
FYI: since this was added the AIX bots (and manual testing) fail for test_asyncio. Shall continue discussion in https://bugs.python.org/issue35545 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a solution to bpo-35545 by adding an optional
flowinfoandscopeidtoasyncio.base_events._ipaddr_infoto carry the full address information into_ipaddr_infoand avoid discarding IPv6 specific information.Changelog entry & regression tests to come.
https://bugs.python.org/issue35545
(cherry picked from commit ac8eb8f)
Co-authored-by: Erwan Le Pape lepaperwan@users.noreply.github.com
https://bugs.python.org/issue35545